netdev - Re: [PATCH iproute2-next v2 2/8] dcb: app: modify dcb-app print functions for dcb-rewr reuse

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230531083141.ijtwsfxa3javczdf@DEN-LT-70577>
Date: Wed, 31 May 2023 08:31:41 +0000
From: Daniel Machon <daniel.machon@...rochip.com>
To: Petr Machata <petrm@...dia.com>
CC: <netdev@...r.kernel.org>, <dsahern@...nel.org>,
	<stephen@...workplumber.org>, <UNGLinuxDriver@...rochip.com>
Subject: Re: [PATCH iproute2-next v2 2/8] dcb: app: modify dcb-app print
 functions for dcb-rewr reuse

> Daniel Machon <daniel.machon@...rochip.com> writes:
> 
> > Where dcb-app requires protocol to be the printed key, dcb-rewr requires
> > it to be the priority. Adapt existing dcb-app print functions for this.
> >
> > dcb_app_print_filtered() has been modified, to take two callbacks; one
> > for printing the entire string (pid and prio), and one for the pid type
> > (dec, hex, dscp, pcp). This saves us for making one dedicated function
> > for each pid type for both app and rewr.
> >
> > dcb_app_print_key_*() functions have been renamed to
> > dcb_app_print_pid_*() to align with new situation. Also, none of them
> > will print the colon anymore.
> >
> > Signed-off-by: Daniel Machon <daniel.machon@...rochip.com>
> 
> There are about four patches included in this one patch: the %d->%u
> change, the colon shenanigans, the renaming, and prototype change of
> dcb_app_print_filtered().
> 
> I think the code is OK, but I would appreciate splitting into a patch
> per feature.

Actually, IMHO, the 'colon shenanigans' does not make much sense in a
patch of its own, since its not really a standalone feature, but rather
some change that is required for the prototype change of
dcb_app_print_filtered?