netdev - Re: [PATCH iproute2-next] treewide: fix indentation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZHcdqoGUEs+Qcfgs@renaissance-vector>
Date: Wed, 31 May 2023 12:12:58 +0200
From: Andrea Claudi <aclaudi@...hat.com>
To: Ido Schimmel <idosch@...sch.org>
Cc: netdev@...r.kernel.org, stephen@...workplumber.org, dsahern@...il.com,
	leon@...nel.org
Subject: Re: [PATCH iproute2-next] treewide: fix indentation

On Wed, May 31, 2023 at 08:47:00AM +0300, Ido Schimmel wrote:
> On Tue, May 30, 2023 at 07:19:53PM +0200, Andrea Claudi wrote:
> > Replace multiple whitespaces with tab where appropriate.
> > 
> > Signed-off-by: Andrea Claudi <aclaudi@...hat.com>
> > ---
> >  bridge/vni.c   |  2 +-
> >  genl/ctrl.c    |  2 +-
> >  ip/ipaddress.c |  2 +-
> >  ip/ipmacsec.c  |  4 ++--
> >  ip/ipprefix.c  |  2 +-
> >  ip/ipvrf.c     |  2 +-
> >  lib/fs.c       |  2 +-
> >  lib/ll_types.c | 10 +++++-----
> >  rdma/dev.c     | 10 +++++-----
> >  tc/m_ipt.c     |  4 ++--
> >  tc/m_xt_old.c  |  4 ++--
> >  tc/q_fq.c      |  8 ++++----
> >  tc/q_htb.c     |  4 ++--
> >  tc/tc_core.c   |  2 +-
> >  14 files changed, 29 insertions(+), 29 deletions(-)
> 
> Thanks for the patch. Do you mind folding this one as well?
> 
> diff --git a/tc/f_flower.c b/tc/f_flower.c
> index 48cfafdbc3c0..d68c9d2a194b 100644
> --- a/tc/f_flower.c
> +++ b/tc/f_flower.c
> @@ -88,7 +88,7 @@ static void explain(void)
>                 "                       enc_ttl MASKED-IP_TTL |\n"
>                 "                       geneve_opts MASKED-OPTIONS |\n"
>                 "                       vxlan_opts MASKED-OPTIONS |\n"
> -               "                       erspan_opts MASKED-OPTIONS |\n"
> +               "                       erspan_opts MASKED-OPTIONS |\n"
>                 "                       gtp_opts MASKED-OPTIONS |\n"
>                 "                       ip_flags IP-FLAGS |\n"
>                 "                       enc_dst_port [ port_number ] |\n"
> 
> Before:
> 
> $ tc filter add flower help 2>&1 | grep opts
>                         geneve_opts MASKED-OPTIONS |
>                         vxlan_opts MASKED-OPTIONS |
>                        erspan_opts MASKED-OPTIONS |
>                         gtp_opts MASKED-OPTIONS |
> 
> After:
> 
> $ tc filter add flower help 2>&1 | grep opts
>                         geneve_opts MASKED-OPTIONS |
>                         vxlan_opts MASKED-OPTIONS |
>                         erspan_opts MASKED-OPTIONS |
>                         gtp_opts MASKED-OPTIONS |
>

Thanks for the review.
I'll include it in v2, and I'll fix another issue in tc flower help.