netdev - RE: [Intel-wired-lan] [PATCH iwl-next v6 12/15] idpf: add RX splitq napi poll support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Tue, 30 May 2023 23:02:53 +0000
From: "Singh, Krishneil K" <krishneil.k.singh@...el.com>
To: "Linga, Pavan Kumar" <pavan.kumar.linga@...el.com>,
	"intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>
CC: "willemb@...gle.com" <willemb@...gle.com>, "pabeni@...hat.com"
	<pabeni@...hat.com>, "leon@...nel.org" <leon@...nel.org>, "mst@...hat.com"
	<mst@...hat.com>, "simon.horman@...igine.com" <simon.horman@...igine.com>,
	"Brandeburg, Jesse" <jesse.brandeburg@...el.com>,
	"stephen@...workplumber.org" <stephen@...workplumber.org>,
	"edumazet@...gle.com" <edumazet@...gle.com>, "Nguyen, Anthony L"
	<anthony.l.nguyen@...el.com>, "netdev@...r.kernel.org"
	<netdev@...r.kernel.org>, "kuba@...nel.org" <kuba@...nel.org>, "Burra, Phani
 R" <phani.r.burra@...el.com>, "decot@...gle.com" <decot@...gle.com>,
	"davem@...emloft.net" <davem@...emloft.net>, "shannon.nelson@....com"
	<shannon.nelson@....com>
Subject: RE: [Intel-wired-lan] [PATCH iwl-next v6 12/15] idpf: add RX splitq
 napi poll support

> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@...osl.org> On Behalf Of
> Pavan Kumar Linga
> Sent: Monday, May 22, 2023 5:23 PM
> To: intel-wired-lan@...ts.osuosl.org
> Cc: willemb@...gle.com; pabeni@...hat.com; leon@...nel.org;
> mst@...hat.com; simon.horman@...igine.com; Brandeburg, Jesse
> <jesse.brandeburg@...el.com>; stephen@...workplumber.org;
> edumazet@...gle.com; Nguyen, Anthony L
> <anthony.l.nguyen@...el.com>; netdev@...r.kernel.org; kuba@...nel.org;
> Burra, Phani R <phani.r.burra@...el.com>; decot@...gle.com;
> davem@...emloft.net; shannon.nelson@....com
> Subject: [Intel-wired-lan] [PATCH iwl-next v6 12/15] idpf: add RX splitq napi
> poll support
> 
> From: Alan Brady <alan.brady@...el.com>
> 
> Add support to handle interrupts for the RX completion queue and
> RX buffer queue. When the interrupt fires on RX completion queue,
> process the RX descriptors that are received. Allocate and prepare
> the SKB with the RX packet info, for both data and header buffer.
> 
> IDPF uses software maintained refill queues to manage buffers between
> RX queue producer and the buffer queue consumer. They are required in
> order to maintain a lockless buffer management system and are strictly
> software only constructs. Instead of updating the RX buffer queue tail
> with available buffers right after the clean routine, it posts the
> buffer ids to the refill queues, only to post them to the HW later.
> 
> If the generic receive offload (GRO) is enabled in the capabilities
> and turned on by default or via ethtool, then HW performs the
> packet coalescing if certain criteria are met by the incoming
> packets and updates the RX descriptor. Similar to GRO, if generic
> checksum is enabled, HW computes the checksum and updates the
> respective fields in the descriptor. Add support to update the
> SKB fields with the GRO and the generic checksum received.
> 
> Signed-off-by: Alan Brady <alan.brady@...el.com>
> Co-developed-by: Joshua Hay <joshua.a.hay@...el.com>
> Signed-off-by: Joshua Hay <joshua.a.hay@...el.com>
> Co-developed-by: Madhu Chittim <madhu.chittim@...el.com>
> Signed-off-by: Madhu Chittim <madhu.chittim@...el.com>
> Co-developed-by: Phani Burra <phani.r.burra@...el.com>
> Signed-off-by: Phani Burra <phani.r.burra@...el.com>
> Co-developed-by: Pavan Kumar Linga <pavan.kumar.linga@...el.com>
> Signed-off-by: Pavan Kumar Linga <pavan.kumar.linga@...el.com>
> Reviewed-by: Sridhar Samudrala <sridhar.samudrala@...el.com>
> Reviewed-by: Willem de Bruijn <willemb@...gle.com>
> ---
>  drivers/net/ethernet/intel/idpf/idpf.h        |   2 +
>  drivers/net/ethernet/intel/idpf/idpf_txrx.c   | 992 +++++++++++++++++-
>  drivers/net/ethernet/intel/idpf/idpf_txrx.h   |  56 +-
>  .../net/ethernet/intel/idpf/idpf_virtchnl.c   |   4 +-
>  4 files changed, 1045 insertions(+), 9 deletions(-)
> 
Tested-by: Krishneil Singh  <krishneil.k.singh@...el.com>