netdev - Re: [PATCH iproute2-next v2 2/8] dcb: app: modify dcb-app print functions for dcb-rewr reuse

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <13135dfb-cf59-4711-ac63-a4384ab31873@kernel.org>
Date: Wed, 31 May 2023 08:28:42 -0600
From: David Ahern <dsahern@...nel.org>
To: Petr Machata <petrm@...dia.com>,
 Daniel Machon <daniel.machon@...rochip.com>
Cc: netdev@...r.kernel.org, stephen@...workplumber.org,
 UNGLinuxDriver@...rochip.com
Subject: Re: [PATCH iproute2-next v2 2/8] dcb: app: modify dcb-app print
 functions for dcb-rewr reuse

On 5/31/23 5:26 AM, Petr Machata wrote:
> It doesn't make sense on its own, but it also does not get sent on its
> own, but together with the following patches. Its role is to set stage.
> 
> dcb_app_print_filtered() should first stop assuming the callback prints
> a colon. So you have one patch where the colon moves from the callback
> to _print_filtered(). That's a clean, behavior-neutral change that
> should be trivial to review. Then next patch introduces the callback.
> Which at that point should likewise be tidy, focused and easy to review,
> because it will only deal with the new callback.

agreed. code should evolve in a way that makes it easy to review.