netdev - RE: [PATCH net-next v3] net: dsa: mv88e6xxx: implement USXGMII mode for mv88e6393x

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID:
 <BYAPR14MB2918A428BA5654A4495321D5E3489@BYAPR14MB2918.namprd14.prod.outlook.com>
Date: Wed, 31 May 2023 17:43:14 +0000
From: Michal Smulski <michal.smulski@...a.com>
To: Simon Horman <simon.horman@...igine.com>
CC: "andrew@...n.ch" <andrew@...n.ch>, "f.fainelli@...il.com"
	<f.fainelli@...il.com>, "olteanv@...il.com" <olteanv@...il.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: RE: [PATCH net-next v3] net: dsa: mv88e6xxx: implement USXGMII mode
 for mv88e6393x

Fixed typo and resubmitted as v4 patch.
Michal

-----Original Message-----
From: Simon Horman <simon.horman@...igine.com> 
Sent: Wednesday, May 31, 2023 9:39 AM
To: Michal Smulski <msmulski2@...il.com>
Cc: andrew@...n.ch; f.fainelli@...il.com; olteanv@...il.com; netdev@...r.kernel.org; Michal Smulski <michal.smulski@...a.com>
Subject: Re: [PATCH net-next v3] net: dsa: mv88e6xxx: implement USXGMII mode for mv88e6393x

CAUTION: This email is originated from outside of the organization. Do not click links or open attachments unless you recognize the sender and know the content is safe.


On Tue, May 30, 2023 at 10:50:10PM -0700, Michal Smulski wrote:
> Enable USXGMII mode for mv88e6393x chips. Tested on Marvell 88E6191X.
>
> Signed-off-by: Michal Smulski <michal.smulski@...a.com>

> @@ -984,6 +985,64 @@ static int mv88e6393x_serdes_pcs_get_state_10g(struct mv88e6xxx_chip *chip,
>                       state->speed = SPEED_10000;
>               state->duplex = DUPLEX_FULL;
>       }
> +     return 0;
> +}
> +
> +/* USXGMII registers for Marvell switch 88e639x are undocumented and this function is based
> + * on some educated guesses. There does not seem to bit status bit related to
> + * autonegotion complete or flow control.

Hi Michal,

: checkpatch --codespell suggests s/autonegotion/autonegotiation/