netdev - Re: [PATCH net v2] net/mlx5: Fix setting of irq->map.index for static IRQ case

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZHfA+i4E3SykRT4O@x130>
Date: Wed, 31 May 2023 14:49:46 -0700
From: Saeed Mahameed <saeed@...nel.org>
To: Cédric Le Goater <clegoate@...hat.com>
Cc: Niklas Schnelle <schnelle@...ux.ibm.com>, Shay Drory <shayd@...dia.com>,
	Saeed Mahameed <saeedm@...dia.com>, Eli Cohen <elic@...dia.com>,
	Leon Romanovsky <leon@...nel.org>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-s390@...r.kernel.org, Mark Brown <broonie@...nel.org>,
	Simon Horman <simon.horman@...igine.com>,
	linux-rdma@...r.kernel.org
Subject: Re: [PATCH net v2] net/mlx5: Fix setting of irq->map.index for
 static IRQ case

On 31 May 11:38, Cédric Le Goater wrote:
>On 5/31/23 10:48, Niklas Schnelle wrote:
>>When dynamic IRQ allocation is not supported all IRQs are allocated up
>>front in mlx5_irq_table_create() instead of dynamically as part of
>>mlx5_irq_alloc(). In the latter dynamic case irq->map.index is set
>>via the mapping returned by pci_msix_alloc_irq_at(). In the static case
>>and prior to commit 1da438c0ae02 ("net/mlx5: Fix indexing of mlx5_irq")
>>irq->map.index was set in mlx5_irq_alloc() twice once initially to 0 and
>>then to the requested index before storing in the xarray. After this
>>commit it is only set to 0 which breaks all other IRQ mappings.
>>
>>Fix this by setting irq->map.index to the requested index together with
>>irq->map.virq and improve the related comment to make it clearer which
>>cases it deals with.
>>
>>Tested-by: Mark Brown <broonie@...nel.org>
>>Reviewed-by: Mark Brown <broonie@...nel.org>
>>Reviewed-by: Simon Horman <simon.horman@...igine.com>
>>Reviewed-by: Eli Cohen <elic@...dia.com>
>>Fixes: 1da438c0ae02 ("net/mlx5: Fix indexing of mlx5_irq")
>>Signed-off-by: Niklas Schnelle <schnelle@...ux.ibm.com>
>

Applied to net-mlx5. 

Thanks.