netdev - RE: [PATCH net-next v2] net: dsa: mv88e6xxx: implement USXGMII mode for mv88e6393x

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID:
 <BYAPR14MB2918D22EAF8998C56EC09443E3489@BYAPR14MB2918.namprd14.prod.outlook.com>
Date: Wed, 31 May 2023 05:54:07 +0000
From: Michal Smulski <michal.smulski@...a.com>
To: Marek Behún <kabel@...nel.org>
CC: Andrew Lunn <andrew@...n.ch>, "f.fainelli@...il.com"
	<f.fainelli@...il.com>, "olteanv@...il.com" <olteanv@...il.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: RE: [PATCH net-next v2] net: dsa: mv88e6xxx: implement USXGMII mode
 for mv88e6393x

I followed your suggestions and came up with version v3 as in my previous email. With that patch, I get a notice of link up in logs.

[   51.658898] mv88e6085 0x0000000008b96000:02: switch 0x1920 detected: Marvell 88E6191X, revision 0
[   52.325920] mv88e6085 0x0000000008b96000:02: configuring for inband/usxgmii link mode
[   52.521309] mv88e6085 0x0000000008b96000:02: Link is Up - 10Gbps/Full - flow control off


Michal

-----Original Message-----
From: Marek Behún <kabel@...nel.org> 
Sent: Tuesday, May 30, 2023 6:54 AM
To: Michal Smulski <michal.smulski@...a.com>
Cc: Andrew Lunn <andrew@...n.ch>; f.fainelli@...il.com; olteanv@...il.com; netdev@...r.kernel.org
Subject: Re: [PATCH net-next v2] net: dsa: mv88e6xxx: implement USXGMII mode for mv88e6393x

CAUTION: This email is originated from outside of the organization. Do not click links or open attachments unless you recognize the sender and know the content is safe.


On Mon, 29 May 2023 17:23:12 +0000
Michal Smulski <michal.smulski@...a.com> wrote:

> If I understand this correctly, you are asking to create a function for USXGMII similar to:
>
> static int mv88e6390_serdes_pcs_get_state_sgmii(struct mv88e6xxx_chip *chip,
>       int port, int lane, struct phylink_link_state *state)
>
> However, the datasheet for 88e6393x chips does not document any registers for USXGMII interface (as it does for SGMII). You can only see that 10G link is valid by looking at MV88E6390_10G_STAT1 & MDIO_STAT1_LSTATUS which has already been implemented in:
> static int mv88e6390_serdes_pcs_get_state_10g(struct mv88e6xxx_chip *chip,
>       int port, int lane, struct phylink_link_state *state) The 
> datasheet states that in USXGMII mode the link is always set to 10GBASE-R coding for all data rates.
>
> From the logs, I see that that the link is configured using in-band information. However, there is no register access in MV88E6393x that would allow to either control or get status information (speed, duplex, flow control, auto-negotiation, etc). Most of "useful" registers are already defined in mv88e6xxx/serdes.h file.
>
> [   50.624175] mv88e6085 0x0000000008b96000:02: configuring for inband/usxgmii link mode
> ...
> [  387.116463] fsl_dpaa2_eth dpni.3 eth1: configuring for 
> inband/usxgmii link mode [  387.132554] fsl_dpaa2_eth dpni.3 eth1: 
> Link is Up - 10Gbps/Full - flow control off
>
> If I misunderstood what is requested, please give me a bit more information what I should be adding for this patch to be accepted.

I know that 6393x does not document the USXGMII registers, but I bet there are there. Similar to how 88X3540 supports USXGMII but the registers are not documented.

Do you have func spec for 88X3310 / 88X3340 ? Those two document some USXGMII registers, and the bits are the same as in this microsemi document
  https://www.microsemi.com/document-portal/doc_view/1245324-coreusxgmii-hb

I don't acutally have access to Cisco's USXGMII specification, but I bet these register bits are same between vendors. Could you at least try to investigate this?

Marek