netdev - Re: [PATCH net-next] devlink: make health report on unregistered instance warn just once

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZHbo95hVv5Fimlna@nanopsycho>
Date: Wed, 31 May 2023 08:28:07 +0200
From: Jiri Pirko <jiri@...nulli.us>
To: Jakub Kicinski <kuba@...nel.org>
Cc: davem@...emloft.net, netdev@...r.kernel.org, edumazet@...gle.com,
	pabeni@...hat.com
Subject: Re: [PATCH net-next] devlink: make health report on unregistered
 instance warn just once

Wed, May 31, 2023 at 03:55:23AM CEST, kuba@...nel.org wrote:
>Devlink health is involved in error recovery. Machines in bad
>state tend to be fairly unreliable, and occasionally get stuck
>in error loops. Even with a reasonable grace period devlink health
>may get a thousand reports in an hour.
>
>In case of reporting on an unregistered devlink instance
>the subsequent reports don't add much value. Switch to
>WARN_ON_ONCE() to avoid flooding dmesg and fleet monitoring
>dashboards.
>
>Signed-off-by: Jakub Kicinski <kuba@...nel.org>

Reviewed-by: Jiri Pirko <jiri@...dia.com>

Thanks!