netdev - Re: [PATCH net-next 3/4] ath10k: Convert to platform remove callback returning void

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZHjEx9i+D0Ppco5P@corigine.com>
Date: Thu, 1 Jun 2023 18:18:15 +0200
From: Simon Horman <simon.horman@...igine.com>
To: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
Cc: Kalle Valo <kvalo@...nel.org>, "David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	ath10k@...ts.infradead.org, linux-wireless@...r.kernel.org,
	netdev@...r.kernel.org, kernel@...gutronix.de
Subject: Re: [PATCH net-next 3/4] ath10k: Convert to platform remove callback
 returning void

On Thu, Jun 01, 2023 at 10:25:55AM +0200, Uwe Kleine-König wrote:
> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is (mostly) ignored
> and this typically results in resource leaks. To improve here there is a
> quest to make the remove callback return void. In the first step of this
> quest all drivers are converted to .remove_new() which already returns
> void.
> 
> Both ath10k platform drivers return zero unconditionally in their remove
> callback, so they can be trivially converted to use .remove_new().
> 
> Also fix on of the more offending whitespace issues in the definition
> of ath10k_snoc_driver.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>

Reviewed-by: Simon Horman <simon.horman@...igine.com>