netdev - Re: [PATCH net 0/2] net/ipv6: skip_notify_on_dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <476ea123-d20a-d9ef-9713-d53bd93f7876@tessares.net>
Date: Thu, 1 Jun 2023 18:18:21 +0200
From: Matthieu Baerts <matthieu.baerts@...sares.net>
To: Eric Dumazet <edumazet@...gle.com>, "David S . Miller"
 <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>,
 Paolo Abeni <pabeni@...hat.com>
Cc: netdev@...r.kernel.org, David Ahern <dsahern@...nel.org>,
 eric.dumazet@...il.com
Subject: Re: [PATCH net 0/2] net/ipv6: skip_notify_on_dev_down fix

Hi Eric,

On 01/06/2023 18:04, Eric Dumazet wrote:
> While reviewing Matthieu Baerts recent patch [1], I found it copied/pasted
> an existing bug around skip_notify_on_dev_down.

Good catch! Indeed, I quickly copied/pasted the code around
skip_notify_on_dev_down to create my RFC without looking for possible
issues in the code.

> First patch is a stable candidate, and second one can simply land
> in net tree.
> 
> https://lore.kernel.org/lkml/20230601-net-next-skip_print_link_becomes_ready-v1-1-c13e64c14095@tessares.net/
> 
> Eric Dumazet (2):
>   net/ipv6: fix bool/int mismatch for skip_notify_on_dev_down
>   net/ipv6: convert skip_notify_on_dev_down sysctl to u8

Thank you for the patches and for having cced me! The modifications look
good to me!

Acked-by: Matthieu Baerts <matthieu.baerts@...sares.net>

Cheers,
Matt
-- 
Tessares | Belgium | Hybrid Access Solutions
www.tessares.net