netdev - Re: [PATCH net-next] r8169: use dev_err_probe in all appropriate places in rtl_init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZHi8worgk2KndZPd@corigine.com>
Date: Thu, 1 Jun 2023 17:44:02 +0200
From: Simon Horman <simon.horman@...igine.com>
To: Heiner Kallweit <hkallweit1@...il.com>
Cc: Jakub Kicinski <kuba@...nel.org>, David Miller <davem@...emloft.net>,
	Realtek linux nic maintainers <nic_swsd@...ltek.com>,
	Eric Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next] r8169: use dev_err_probe in all appropriate
 places in rtl_init_one()

On Wed, May 31, 2023 at 10:41:32PM +0200, Heiner Kallweit wrote:
> In addition to properly handling probe deferrals dev_err_probe()
> conveniently combines printing an error message with returning
> the errno. So let's use it for every error path in rtl_init_one()
> to simplify the code.
> 
> Signed-off-by: Heiner Kallweit <hkallweit1@...il.com>

Reviewed-by: Simon Horman <simon.horman@...igine.com>