netdev - Re: [PATCH net-next v1 1/1] ieee802154: ca8210: Remove stray gpiod

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZHjIHZv4o8JaX7Dt@smile.fi.intel.com>
Date: Thu, 1 Jun 2023 19:32:29 +0300
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Miquel Raynal <miquel.raynal@...tlin.com>
Cc: Stefan Schmidt <stefan@...enfreihafen.org>, linux-wpan@...r.kernel.org,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	Alexander Aring <alex.aring@...il.com>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>
Subject: Re: [PATCH net-next v1 1/1] ieee802154: ca8210: Remove stray
 gpiod_unexport() call

On Mon, May 29, 2023 at 10:12:13AM +0200, Miquel Raynal wrote:
> andriy.shevchenko@...ux.intel.com wrote on Sun, 28 May 2023 17:09:38
> +0300:
> 
> > There is no gpiod_export() and gpiod_unexport() looks pretty much stray.
> > The gpiod_export() and gpiod_unexport() shouldn't be used in the code,
> > GPIO sysfs is deprecated. That said, simply drop the stray call.
> > 
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> 
> Any reason not to consider a backport into stable kernels?
> Cc: stable + Fixes would certainly be welcome in this case?

I don't think it's justified for stable. It doesn't fix any existing regression
as far as I understand.

-- 
With Best Regards,
Andy Shevchenko