netdev - Re: [PATCH v4 1/6] netlink: Reverse the patch which removed filtering

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <B8F9063A-8121-4D32-99AE-C547B653A57D@oracle.com>
Date: Thu, 1 Jun 2023 16:49:34 +0000
From: Anjali Kulkarni <anjali.k.kulkarni@...cle.com>
To: Jakub Kicinski <kuba@...nel.org>
CC: "davem@...emloft.net" <davem@...emloft.net>,
        "edumazet@...gle.com"
	<edumazet@...gle.com>,
        "pabeni@...hat.com" <pabeni@...hat.com>,
        "zbr@...emap.net" <zbr@...emap.net>,
        "brauner@...nel.org"
	<brauner@...nel.org>,
        "johannes@...solutions.net"
	<johannes@...solutions.net>,
        "ecree.xilinx@...il.com"
	<ecree.xilinx@...il.com>,
        "leon@...nel.org" <leon@...nel.org>,
        "keescook@...omium.org" <keescook@...omium.org>,
        "socketcan@...tkopp.net"
	<socketcan@...tkopp.net>,
        "petrm@...dia.com" <petrm@...dia.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH v4 1/6] netlink: Reverse the patch which removed filtering



> On Jun 1, 2023, at 9:43 AM, Jakub Kicinski <kuba@...nel.org> wrote:
> 
> On Thu, 1 Jun 2023 16:34:08 +0000 Anjali Kulkarni wrote:
>>> The code may have security implications, I really don't feel like I can
>>> be the sole reviewer. There's a bunch of experts working at Oracle,
>>> maybe you could get one of them to put their name on it? I can apply
>>> the patches, I just want to be sure I'm not the _only_ reviewer.  
>> 
>> Thanks so much for your response. There is someone at Oracle who
>> looked at this some time ago and is familiar enough with this to
>> review the code - but he is not a kernel committer - he sends
>> occasional patches upstream which get committed - would it be ok if
>> he reviewed it along with you and then you could commit it? If you
>> know of someone from Oracle who could also potentially review it,
>> please let me know. 
> 
> I meant someone seasoned. IMHO one of the benefits of employing
> upstream experts for corporation like Oracle should be that you
> can lean on them for reviews:
> 
> $ git log --format='%ae' --author='Oracle' --since='2 years ago' | sort | uniq -c | sort -rn
>    811 willy@...radead.org
>    312 rmk+kernel@...linux.org.uk
>     91 Liam.Howlett@...cle.com
>     60 vishal.moola@...il.com
> 
> $ git log --format='%ae' --author='@...cle.com' --since='2 years ago' | sort | uniq -c | sort -rn | head -10
>    451 chuck.lever@...cle.com
>    154 michael.christie@...cle.com
>    118 nick.alcock@...cle.com
>     71 martin.petersen@...cle.com
>     59 mike.kravetz@...cle.com
>     58 sidhartha.kumar@...cle.com
>     55 liam.howlett@...cle.com
>     53 anand.jain@...cle.com
>     32 dai.ngo@...cle.com
>     32 allison.henderson@...cle.com

Thanks, let me check.
Anjali