netdev - RE: [PATCH net-next] net: phy: smsc: add WoL support to LAN8740/LAN8742 PHYs.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BYAPR11MB35584E92C5EA85D79800528FEC489@BYAPR11MB3558.namprd11.prod.outlook.com>
Date: Wed, 31 May 2023 22:52:22 +0000
From: <Tristram.Ha@...rochip.com>
To: <simon.horman@...igine.com>
CC: <davem@...emloft.net>, <andrew@...n.ch>, <f.fainelli@...il.com>,
	<netdev@...r.kernel.org>, <UNGLinuxDriver@...rochip.com>
Subject: RE: [PATCH net-next] net: phy: smsc: add WoL support to
 LAN8740/LAN8742 PHYs.

> > +     if (wol->wolopts & WAKE_ARP) {
> > +             const u8 *ip_addr =
> > +                     ((const u8 *)&((ndev->ip_ptr)->ifa_list)->ifa_address);
> 
> Hi Tristram,
> 
> Sparse seems unhappy about this:
> 
> .../smsc.c:449:27: warning: cast removes address space '__rcu' of expression
> 

This will be fixed with in_dev_get() and rcu_dereference().

> > +             /* Try to match IPv6 Neighbor Solicitation. */
> > +             if (ndev->ip6_ptr) {
> > +                     struct list_head *addr_list =
> > +                             &ndev->ip6_ptr->addr_list;
> 
> And this:
> 
> .../smsc.c:485:38: warning: incorrect type in initializer (different address spaces)
> .../smsc.c:485:38:    expected struct list_head *addr_list
> .../smsc.c:485:38:    got struct list_head [noderef] __rcu *
> .../smsc.c:449:45: warning: dereference of noderef expression
> 
> Please make sure that patches don't intoduce new warnings with W=1 C=1 builds.

This will be fixed with in6_dev_get().

> > +#define MII_LAN874X_PHY_PME1_SET             (2<<13)
> > +#define MII_LAN874X_PHY_PME2_SET             (2<<11)
> 
> nit: Maybe GENMASK is appropriate here.
>      If not, please consider spaces around '<<'

Will update.