netdev - Re: [PATCH net-next v2 1/2] dt-bindings: net: adin: document a phy link status inversion property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6e0c87e0-224f-c68b-9ce5-446e1b7334c1@sord.co.jp>
Date: Thu, 1 Jun 2023 09:29:01 +0900
From: Atsushi Nemoto <atsushi.nemoto@...d.co.jp>
To: Andrew Lunn <andrew@...n.ch>
Cc: netdev@...r.kernel.org, devicetree@...r.kernel.org,
 Michael Hennerich <michael.hennerich@...log.com>,
 Alexandru Tachici <alexandru.tachici@...log.com>,
 "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
 Rob Herring <robh+dt@...nel.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
 Conor Dooley <conor+dt@...nel.org>,
 Horatiu Vultur <horatiu.vultur@...rochip.com>
Subject: Re: [PATCH net-next v2 1/2] dt-bindings: net: adin: document a phy
 link status inversion property

On 2023/05/31 23:35, Andrew Lunn wrote:
>> The ADIN1200/ADIN1300 supports inverting the link status output signal
>> on the LINK_ST pin.
> 
> Please could you add an explanation to the commit message why you
> would want to do this?  Is this because there is an LED connected to
> it, but its polarity is inverted?

Yes, the LINK_ST pin of AD1200/1300 is active-high but our custom
board designer connected it to an LED as an active-low signal.

I'd like to change the description as follows:

---
The ADIN1200/ADIN1300 supports inverting the link status output signal
on the LINK_ST pin.

The LINK_ST is active-high by default. This can be inverted by the
GE_LNK_STAT_INV_REG register, meaning that link up is indicated by
setting LINK_ST low.

Add support for selecting this feature via device-tree properties.

---
Atsushi Nemoto