netdev - Re: [PATCH net] net: phylink: actually fix ksettings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZHhfZo3ktuRe1CjK@shell.armlinux.org.uk>
Date: Thu, 1 Jun 2023 10:05:42 +0100
From: "Russell King (Oracle)" <linux@...linux.org.uk>
To: Andrew Lunn <andrew@...n.ch>, Heiner Kallweit <hkallweit1@...il.com>
Cc: "David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	netdev@...r.kernel.org
Subject: Re: [PATCH net] net: phylink: actually fix ksettings_set() ethtool
 call

Please ignore this, wrong version of the patch. :/ More coffee needed.

On Thu, Jun 01, 2023 at 10:02:07AM +0100, Russell King (Oracle) wrote:
> Raju Lakkaraju reported that the below commit caused a regression
> with Lan743x drivers and a 2.5G SFP. Sadly, this is because the commit
> was utterly wrong. Let's fix this properly by not moving the
> linkmode_and(), but instead copying the link ksettings and then
> modifying the advertising mask before passing the modified link
> ksettings to phylib.
> 
> Fixes: df0acdc59b09 ("net: phylink: fix ksettings_set() ethtool call")
> Signed-off-by: Russell King (Oracle) <rmk+kernel@...linux.org.uk>
> ---
>  drivers/net/phy/phylink.c | 13 +++++++++----
>  1 file changed, 9 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/net/phy/phylink.c b/drivers/net/phy/phylink.c
> index e237949deee6..cf4e51e48cdd 100644
> --- a/drivers/net/phy/phylink.c
> +++ b/drivers/net/phy/phylink.c
> @@ -2225,11 +2225,13 @@ int phylink_ethtool_ksettings_set(struct phylink *pl,
>  
>  	ASSERT_RTNL();
>  
> -	/* Mask out unsupported advertisements */
> -	linkmode_and(config.advertising, kset->link_modes.advertising,
> -		     pl->supported);
> -
>  	if (pl->phydev) {
> +		struct ethtool_link_ksettings phy_kset = *kset;
> +
> +		linkmode_and(phy_kset.link_modes.advertising,
> +			     phy_kset.link_modes.advertising,
> +			     pl->supported);
> +
>  		/* We can rely on phylib for this update; we also do not need
>  		 * to update the pl->link_config settings:
>  		 * - the configuration returned via ksettings_get() will come
> @@ -2252,6 +2254,9 @@ int phylink_ethtool_ksettings_set(struct phylink *pl,
>  	}
>  
>  	config = pl->link_config;
> +	/* Mask out unsupported advertisements */
> +	linkmode_and(config.advertising, kset->link_modes.advertising,
> +		     pl->supported);
>  
>  	/* FIXME: should we reject autoneg if phy/mac does not support it? */
>  	switch (kset->base.autoneg) {
> -- 
> 2.30.2
> 
> 

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!