netdev - RE: [PATCH linux] net/ipv4: ping_group_range: allow GID from 2147483648 to 4294967294

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b613cbaf569945e3811609a9f10fe0aa@AcuMS.aculab.com>
Date: Fri, 2 Jun 2023 10:51:50 +0000
From: David Laight <David.Laight@...LAB.COM>
To: 'Kuniyuki Iwashima' <kuniyu@...zon.com>, "edumazet@...gle.com"
	<edumazet@...gle.com>
CC: "akihiro.suda.cz@....ntt.co.jp" <akihiro.suda.cz@....ntt.co.jp>,
	"akihirosuda@....sr.ht" <akihirosuda@....sr.ht>, "davem@...emloft.net"
	<davem@...emloft.net>, "kuba@...nel.org" <kuba@...nel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>, "pabeni@...hat.com"
	<pabeni@...hat.com>, "segoon@...nwall.com" <segoon@...nwall.com>,
	"suda.kyoto@...il.com" <suda.kyoto@...il.com>
Subject: RE: [PATCH linux] net/ipv4: ping_group_range: allow GID from
 2147483648 to 4294967294

From: Kuniyuki Iwashima
> Sent: 01 June 2023 00:00
....
> > > --- a/include/net/ping.h
> > > +++ b/include/net/ping.h
> > > @@ -20,7 +20,7 @@
> > >   * gid_t is either uint or ushort.  We want to pass it to
> > >   * proc_dointvec_minmax(), so it must not be larger than MAX_INT
> > >   */
> > > -#define GID_T_MAX (((gid_t)~0U) >> 1)
> > > +#define GID_T_MAX ((gid_t)~0U)

Doesn't that comment need updating?

I do wonder how much code breaks for gid > MAXINT.
How much testing does it actually get??

	David

-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)