netdev - Re: [PATCH net 1/2] net/ipv6: fix bool/int mismatch for skip_notify_on_dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7d28139c-c348-c5cc-1e5f-b58b99772905@kernel.org>
Date: Thu, 1 Jun 2023 18:46:10 -0600
From: David Ahern <dsahern@...nel.org>
To: Eric Dumazet <edumazet@...gle.com>, "David S . Miller"
 <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>,
 Paolo Abeni <pabeni@...hat.com>
Cc: netdev@...r.kernel.org, Matthieu Baerts <matthieu.baerts@...sares.net>,
 eric.dumazet@...il.com
Subject: Re: [PATCH net 1/2] net/ipv6: fix bool/int mismatch for
 skip_notify_on_dev_down

On 6/1/23 10:04 AM, Eric Dumazet wrote:
> skip_notify_on_dev_down ctl table expects this field
> to be an int (4 bytes), not a bool (1 byte).
> 
> Because proc_dou8vec_minmax() was added in 5.13,
> this patch converts skip_notify_on_dev_down to an int.
> 
> Following patch then converts the field to u8 and use proc_dou8vec_minmax().
> 
> Fixes: 7c6bb7d2faaf ("net/ipv6: Add knob to skip DELROUTE message on device down")
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> Cc: David Ahern <dsahern@...nel.org>
> ---
>  include/net/netns/ipv6.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 

Reviewed-by: David Ahern <dsahern@...nel.org>