netdev - Re: [PATCH RFC v2 net-next 14/28] p4tc: add table create, update, delete, get, flush and dump

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CALnP8ZbeMnSL_aHnzK-V=exWNCKjcpZf5P0x8XukJeooX4KxKg@mail.gmail.com>
Date: Fri, 2 Jun 2023 14:54:45 -0700
From: Marcelo Ricardo Leitner <mleitner@...hat.com>
To: Jamal Hadi Salim <jhs@...atatu.com>
Cc: netdev@...r.kernel.org, deb.chatterjee@...el.com, anjali.singhai@...el.com, 
	namrata.limaye@...el.com, tom@...anda.io, p4tc-discussions@...devconf.info, 
	Mahesh.Shirshyad@....com, Vipin.Jain@....com, tomasz.osinski@...el.com, 
	jiri@...nulli.us, xiyou.wangcong@...il.com, davem@...emloft.net, 
	edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com, vladbu@...dia.com, 
	simon.horman@...igine.com, khalidm@...dia.com, toke@...hat.com
Subject: Re: [PATCH RFC v2 net-next 14/28] p4tc: add table create, update,
 delete, get, flush and dump

On Wed, May 17, 2023 at 07:02:18AM -0400, Jamal Hadi Salim wrote:
...
> ___Initial Table Entries___
...
> They would get:
>
> pipeline id 22
>     table id 1
>     table name cb/tname
>     key_sz 64
>     max entries 256
>     masks 8
>     table entries 1
>     permissions CRUD--R--X
>     entry:
>         table id 1
>         entry priority 17
>         key blob    101010a0a0a0a
>         mask blob   ffffff00ffffff

I'm wondering how these didn't align. Perhaps key had an extra 0 to
the left? It would be nice to right-align it.

>         create whodunnit tc
>         permissions -RUD--R--X
>
...
> +static int tcf_key_try_set_state_ready(struct p4tc_table_key *key,
> +				       struct netlink_ext_ack *extack)
> +{
> +	if (!key->key_acts) {
> +		NL_SET_ERR_MSG(extack,
> +			       "Table key must have actions before sealing pipelline");

While at it, so that I don't forget stuff..
s/pipelline/pipeline/

> +		return -EINVAL;
> +	}
> +
> +	return 0;
> +}
> +
> +static int __tcf_table_try_set_state_ready(struct p4tc_table *table,
> +					   struct netlink_ext_ack *extack)
> +{
> +	int i;
> +	int ret;
> +
> +	if (!table->tbl_postacts) {
> +		NL_SET_ERR_MSG(extack,
> +			       "All tables must have postactions before sealing pipelline");

Same.