netdev - RE: [PATCH net-next v6 1/1] net: dsa: mv88e6xxx: implement USXGMII mode for mv88e6393x

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <BYAPR14MB2918BDA8AAEC5413A0CD523EE34FA@BYAPR14MB2918.namprd14.prod.outlook.com>
Date: Sat, 3 Jun 2023 04:32:09 +0000
From: Michal Smulski <michal.smulski@...a.com>
To: Marek Behún <kabel@...nel.org>
CC: "andrew@...n.ch" <andrew@...n.ch>, "f.fainelli@...il.com"
	<f.fainelli@...il.com>, "olteanv@...il.com" <olteanv@...il.com>,
	"davem@...emloft.net" <davem@...emloft.net>, "edumazet@...gle.com"
	<edumazet@...gle.com>, "kuba@...nel.org" <kuba@...nel.org>,
	"pabeni@...hat.com" <pabeni@...hat.com>, "linux@...linux.org.uk"
	<linux@...linux.org.uk>, "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"simon.horman@...igine.com" <simon.horman@...igine.com>
Subject: RE: [PATCH net-next v6 1/1] net: dsa: mv88e6xxx: implement USXGMII
 mode for mv88e6393x

Thank you for the review. I will make the change on the next version of this patch.
Michal

-----Original Message-----
From: Marek Behún <kabel@...nel.org> 
Sent: Friday, June 2, 2023 12:54 AM
To: msmulski2@...il.com
Cc: andrew@...n.ch; f.fainelli@...il.com; olteanv@...il.com; davem@...emloft.net; edumazet@...gle.com; kuba@...nel.org; pabeni@...hat.com; linux@...linux.org.uk; netdev@...r.kernel.org; linux-kernel@...r.kernel.org; simon.horman@...igine.com; Michal Smulski <michal.smulski@...a.com>
Subject: Re: [PATCH net-next v6 1/1] net: dsa: mv88e6xxx: implement USXGMII mode for mv88e6393x

CAUTION: This email is originated from outside of the organization. Do not click links or open attachments unless you recognize the sender and know the content is safe.


On Thu,  1 Jun 2023 17:17:04 -0700
msmulski2@...il.com wrote:

>                               config->mac_capabilities |= MAC_5000FD |
>                                       MAC_10000FD;
>                       }
> -                     /* FIXME: USXGMII is not supported yet */
> -                     /* __set_bit(PHY_INTERFACE_MODE_USXGMII, supported); */
> +                     __set_bit(PHY_INTERFACE_MODE_USXGMII, 
> + supported);
>               }
>       }

The set_bit() should go into the if statement above, since 6361 does not support usxgmii:

 /* 6361 only supports up to 2500BaseX */  if (!is_6361) {
        __set_bit(PHY_INTERFACE_MODE_5GBASER, supported);
        __set_bit(PHY_INTERFACE_MODE_10GBASER, supported);
+       __set_bit(PHY_INTERFACE_MODE_USXGMII, supported);
        config->mac_capabilities |= MAC_5000FD |
                MAC_10000FD;
 }
-/* FIXME: USXGMII is not supported yet */
-/* __set_bit(PHY_INTERFACE_MODE_USXGMII, supported); */




Marek