netdev - Re: [net-next 03/14] net/mlx5e: rep, store send to vport rules per peer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZHrq5QjAeUjRv/yv@corigine.com>
Date: Sat, 3 Jun 2023 09:25:25 +0200
From: Simon Horman <simon.horman@...igine.com>
To: Saeed Mahameed <saeed@...nel.org>
Cc: "David S. Miller" <davem@...emloft.net>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Eric Dumazet <edumazet@...gle.com>,
	Saeed Mahameed <saeedm@...dia.com>, netdev@...r.kernel.org,
	Tariq Toukan <tariqt@...dia.com>, Mark Bloch <mbloch@...dia.com>,
	Shay Drory <shayd@...dia.com>, Roi Dayan <roid@...dia.com>
Subject: Re: [net-next 03/14] net/mlx5e: rep, store send to vport rules per
 peer

On Fri, Jun 02, 2023 at 11:46:31AM -0700, Saeed Mahameed wrote:
> On 02 Jun 18:02, Simon Horman wrote:
> > On Wed, May 31, 2023 at 11:01:07PM -0700, Saeed Mahameed wrote:
> > > From: Mark Bloch <mbloch@...dia.com>
> > > 
> > > Each representor, for each send queue, is holding a
> > > send_to_vport rule for the peer eswitch.
> > > 
> > > In order to support more than one peer, and to map between the peer
> > > rules and peer eswitches, refactor representor to hold both the peer
> > > rules and pointer to the peer eswitches.
> > > This enables mlx5 to store send_to_vport rules per peer, where each
> > > peer have dedicate index via mlx5_get_dev_index().
> > > 
> > > Signed-off-by: Mark Bloch <mbloch@...dia.com>
> > > Signed-off-by: Shay Drory <shayd@...dia.com>
> > > Reviewed-by: Roi Dayan <roid@...dia.com>
> > > Signed-off-by: Saeed Mahameed <saeedm@...dia.com>
> > 
> > ...
> > 
> > > @@ -426,15 +437,24 @@ static int mlx5e_sqs2vport_start(struct mlx5_eswitch *esw,
> > >  		rep_sq->sqn = sqns_array[i];
> > > 
> > >  		if (peer_esw) {
> > > +			int peer_rule_idx = mlx5_get_dev_index(peer_esw->dev);
> > > +
> > > +			sq_peer = kzalloc(sizeof(*sq_peer), GFP_KERNEL);
> > > +			if (!sq_peer)
> > > +				goto out_sq_peer_err;
> > 
> > Hi Mark and Saeed,
> > 
> > Jumping to out_sq_peer_err will return err.
> > But err seems to be uninitialised here.
> > 
> 
> Thanks Simon, They change this logic in a later refactoring patch:
> "net/mlx5: Devcom, introduce devcom_for_each_peer_entry" where this issue
> doesn't exist anymore, but i will fix anyway..

Thanks, much appreciated.