netdev - Re: [PATCH net-next 2/4] tools: ynl: user space helpers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZHtSbn1oHl4KcfUL@corigine.com>
Date: Sat, 3 Jun 2023 16:47:10 +0200
From: Simon Horman <simon.horman@...igine.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: davem@...emloft.net, netdev@...r.kernel.org, edumazet@...gle.com,
	pabeni@...hat.com
Subject: Re: [PATCH net-next 2/4] tools: ynl: user space helpers

On Fri, Jun 02, 2023 at 10:25:45PM -0700, Jakub Kicinski wrote:
> Add "fixed" part of the user space Netlink Spec-based library.
> This will get linked with the protocol implementations to form
> a full API.
> 
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>

Hi Jakub,

some very minor nits from my side.

> +/**
> + * struct ynl_error - error encountered by YNL
> + * Users should interact with the err member of struct ynl_sock directly.
> + * The main exception to that rule is ynl_sock_create().

nit: As this is a kernel doc, maybe document the structure members here.

> + */
> +struct ynl_error {
> +	enum ynl_error_code code;
> +	unsigned int attr_offs;
> +	char msg[512];
> +};
> +
> +/**
> + * struct ynl_family - YNL family info
> + * Family description generated by codegen.

And here.

> + */
> +struct ynl_family {
> +	const char *name;
> +	const struct ynl_ntf_info *ntf_info;
> +	unsigned int ntf_info_size;
> +};

...

> +/**
> + * ynl_has_ntf() - check if socket has *parsed* notifications
> + * Note that this does not take into account notifications sitting
> + * in netlink socket, just the notifications which have already been
> + * read and parsed (e.g. during a ynl_ntf_check() call).

And the parameter of this function here.

> + */
> +static inline bool ynl_has_ntf(struct ynl_sock *ys)
> +{
> +	return ys->ntf_last_next != &ys->ntf_first;
> +}

...