netdev - Re: [PATCH net] net: sfp: fix state loss when updating state_hw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <842907db-6450-4032-b0d6-a3de5b230258@lunn.ch>
Date: Sat, 3 Jun 2023 20:22:18 +0200
From: Andrew Lunn <andrew@...n.ch>
To: David Miller <davem@...emloft.net>
Cc: Russell King <rmk+kernel@...linux.org.uk>, hkallweit1@...il.com,
	davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
	pabeni@...hat.com, netdev@...r.kernel.org
Subject: Re: [PATCH net] net: sfp: fix state loss when updating state_hw_mask

On Sun, Mar 19, 2023 at 11:10:16AM +0000, patchwork-bot+netdevbpf@...nel.org wrote:
> Hello:
> 
> This patch was applied to netdev/net.git (main)
> by David S. Miller <davem@...emloft.net>:
> 
> On Fri, 17 Mar 2023 07:28:00 +0000 you wrote:
> > Andrew reports that the SFF modules on one of the ZII platforms do not
> > indicate link up due to the SFP code believing that LOS indicating that
> > there is no signal being received from the remote end, but in fact the
> > LOS signal is showing that there is signal.
> > 
> > What makes SFF modules different from SFPs is they typically have an
> > inverted LOS, which uncovered this issue. When we read the hardware
> > state, we mask it with state_hw_mask so we ignore anything we're not
> > interested in. However, we don't re-read when state_hw_mask changes,
> > leading to sfp->state being stale.
> > 
> > [...]
> 
> Here is the summary with links:
>   - [net] net: sfp: fix state loss when updating state_hw_mask
>     https://git.kernel.org/netdev/net/c/04361b8bb818

Hi David

This patch was submitted to net, and we can see it was also merged to
netdev/net.git. The Fixes tag of 8475c4b70b04 indicates the problem
was introduced in v6.1-rc1. Yet this fix does not appear in v6.1.31.

Do you have any idea why it has not been backported? It does cleanly
cherry-pick.

Thanks
	Andrew