netdev - Re: [PATCH v2] ARM: dts: vf610: ZII: Add missing phy-mode and fixed links

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20230604123504.GJ4199@dragon>
Date: Sun, 4 Jun 2023 20:35:04 +0800
From: Shawn Guo <shawnguo@...nel.org>
To: "Russell King (Oracle)" <linux@...linux.org.uk>
Cc: Vladimir Oltean <vladimir.oltean@....com>, Andrew Lunn <andrew@...n.ch>,
	s.hauer@...gutronix.de, arm@...nel.org,
	netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH v2] ARM: dts: vf610: ZII: Add missing phy-mode and fixed
 links

On Sun, Jun 04, 2023 at 01:24:35PM +0100, Russell King (Oracle) wrote:
> On Sun, Jun 04, 2023 at 08:07:48PM +0800, Shawn Guo wrote:
> > On Mon, May 29, 2023 at 04:35:07PM +0300, Vladimir Oltean wrote:
> > > On Thu, May 25, 2023 at 08:26:06PM +0200, Andrew Lunn wrote:
...
> > > > diff --git a/arch/arm/boot/dts/vf610-zii-ssmb-spu3.dts b/arch/arm/boot/dts/vf610-zii-ssmb-spu3.dts
> > > > index 20beaa8433b6..f5ae0d5de315 100644
> > > > --- a/arch/arm/boot/dts/vf610-zii-ssmb-spu3.dts
> > > > +++ b/arch/arm/boot/dts/vf610-zii-ssmb-spu3.dts
> > > > @@ -154,7 +154,7 @@ ports {
> > > >  
> > > >  				port@0 {
> > > >  					reg = <0>;
> > > > -					label = "cpu";
> > > > +					phy-mode = "rmii";
> > > >  					ethernet = <&fec1>;
> > > >  
> > > >  					fixed-link {
> > > 
> > > Shouldn't these have been rev-rmii to be consistent with what was done
> > > for arm64?
> > 
> > Should I drop the patch for now, or can this be changed incrementally if
> > needed?
> 
> What we have here is something that is "close enough". It isn't 100%
> correct, but acceptable for the time being, and isn't something that
> will ever become a problem, since the hardware itself can not have
> its interface mode changed (it's set by pin strapping.)
> 
> It's something that can be fixed later.

Thanks for the clarification, Russell!

Shawn