netdev - Re: [PATCH ipsec-next] xfrm: delete not-needed clear to zero of encap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZH2h7xp7FFq/LOC4@gondor.apana.org.au>
Date: Mon, 5 Jun 2023 16:50:55 +0800
From: Herbert Xu <herbert@...dor.apana.org.au>
To: Leon Romanovsky <leon@...nel.org>
Cc: Steffen Klassert <steffen.klassert@...unet.com>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, netdev@...r.kernel.org,
	Paolo Abeni <pabeni@...hat.com>
Subject: Re: [PATCH ipsec-next] xfrm: delete not-needed clear to zero of
 encap_oa

On Mon, Jun 05, 2023 at 11:48:29AM +0300, Leon Romanovsky wrote:
>
> It is impossible to remove encap_oa because it is declared as UAPI.
> 
> Unless you want to support some out-of-tree code, uep->encap_oa will
> be always zero.

No we should keep it.  This has been a wart on our stack as it
basically breaks down when the peer shifts addresses.  We should
start using encap_oa in some way and fix this.

Cheers,
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt