netdev - Re: [PATCH net 3/4] igc: Retrieve TX timestamp during interrupt handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230605-distort-jab-ce1f3ece058a-mkl@pengutronix.de>
Date: Mon, 5 Jun 2023 13:16:37 +0200
From: Marc Kleine-Budde <mkl@...gutronix.de>
To: Tony Nguyen <anthony.l.nguyen@...el.com>
Cc: davem@...emloft.net, kuba@...nel.org, pabeni@...hat.com,
	edumazet@...gle.com, netdev@...r.kernel.org,
	Vinicius Costa Gomes <vinicius.gomes@...el.com>,
	sasha.neftin@...el.com, richardcochran@...il.com,
	Kurt Kanzenbach <kurt@...utronix.de>,
	Naama Meir <naamax.meir@...ux.intel.com>
Subject: Re: [PATCH net 3/4] igc: Retrieve TX timestamp during interrupt
 handling

On 30.05.2023 10:49:27, Tony Nguyen wrote:
> From: Vinicius Costa Gomes <vinicius.gomes@...el.com>
> 
> When the interrupt is handled, the TXTT_0 bit in the TSYNCTXCTL
> register should already be set and the timestamp value already loaded
> in the appropriate register.
> 
> This simplifies the handling, and reduces the latency for retrieving
> the TX timestamp, which increase the amount of TX timestamps that can
> be handled in a given time period.

What about renaming the igc_ptp_tx_work() function, as it's not
scheduled work anymore, also IMHO you should update the function's
comment.

Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde          |
Embedded Linux                   | https://www.pengutronix.de |
Vertretung Nürnberg              | Phone: +49-5121-206917-129 |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-9   |

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)