netdev - Re: [PATCH 17/21] power: reset: at91-poweroff: lookup for proper pmc dt node for sam9x7

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c3f7c08f-272a-5abb-da78-568c408f40de@microchip.com>
Date: Mon, 5 Jun 2023 15:04:34 +0200
From: Nicolas Ferre <nicolas.ferre@...rochip.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>, Varshini Rajendran
	<varshini.rajendran@...rochip.com>, <tglx@...utronix.de>, <maz@...nel.org>,
	<robh+dt@...nel.org>, <krzysztof.kozlowski+dt@...aro.org>,
	<conor+dt@...nel.org>, <alexandre.belloni@...tlin.com>,
	<claudiu.beznea@...rochip.com>, <davem@...emloft.net>, <edumazet@...gle.com>,
	<kuba@...nel.org>, <pabeni@...hat.com>, <gregkh@...uxfoundation.org>,
	<linux@...linux.org.uk>, <mturquette@...libre.com>, <sboyd@...nel.org>,
	<sre@...nel.org>, <broonie@...nel.org>, <arnd@...db.de>,
	<gregory.clement@...tlin.com>, <sudeep.holla@....com>,
	<balamanikandan.gunasundar@...rochip.com>, <mihai.sain@...rochip.com>,
	<linux-kernel@...r.kernel.org>, <devicetree@...r.kernel.org>,
	<linux-arm-kernel@...ts.infradead.org>, <netdev@...r.kernel.org>,
	<linux-usb@...r.kernel.org>, <linux-clk@...r.kernel.org>,
	<linux-pm@...r.kernel.org>
CC: <Hari.PrasathGE@...rochip.com>, <cristian.birsan@...rochip.com>,
	<durai.manickamkr@...rochip.com>, <manikandan.m@...rochip.com>,
	<dharma.b@...rochip.com>, <nayabbasha.sayed@...rochip.com>,
	<balakrishnan.s@...rochip.com>
Subject: Re: [PATCH 17/21] power: reset: at91-poweroff: lookup for proper pmc
 dt node for sam9x7

On 05/06/2023 at 08:43, Krzysztof Kozlowski wrote:
> On 03/06/2023 22:02, Varshini Rajendran wrote:
>> Use sam9x7 pmc's compatible to lookup for in the SHDWC driver
>>
>> Signed-off-by: Varshini Rajendran <varshini.rajendran@...rochip.com>
>> ---
>>   drivers/power/reset/at91-sama5d2_shdwc.c | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/power/reset/at91-sama5d2_shdwc.c b/drivers/power/reset/at91-sama5d2_shdwc.c
>> index d8ecffe72f16..d0f29b99f25e 100644
>> --- a/drivers/power/reset/at91-sama5d2_shdwc.c
>> +++ b/drivers/power/reset/at91-sama5d2_shdwc.c
>> @@ -326,6 +326,7 @@ static const struct of_device_id at91_pmc_ids[] = {
>>        { .compatible = "atmel,sama5d2-pmc" },
>>        { .compatible = "microchip,sam9x60-pmc" },
>>        { .compatible = "microchip,sama7g5-pmc" },
>> +     { .compatible = "microchip,sam9x7-pmc" },
> 
> Why do you need new entry if these are compatible?

Yes, PMC is very specific to a SoC silicon. As we must look for it in 
the shutdown controller, I think we need a new entry here.

Best regards,
   Nicolas

-- 
Nicolas Ferre