[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20230605151514.20112956@pc-7.home>
Date: Mon, 5 Jun 2023 15:15:14 +0200
From: Maxime Chevallier <maxime.chevallier@...tlin.com>
To: Mark Brown <broonie@...nel.org>, davem@...emloft.net
Cc: netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
alexis.lothore@...tlin.com, thomas.petazzoni@...tlin.com, Andrew Lunn
<andrew@...n.ch>, Jakub Kicinski <kuba@...nel.org>, Eric Dumazet
<edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>, Florian Fainelli
<f.fainelli@...il.com>, Heiner Kallweit <hkallweit1@...il.com>, Russell
King <linux@...linux.org.uk>, Vladimir Oltean <vladimir.oltean@....com>,
Ioana Ciornei <ioana.ciornei@....com>,
linux-stm32@...md-mailman.stormreply.com,
linux-arm-kernel@...ts.infradead.org, Maxime Coquelin
<mcoquelin.stm32@...il.com>, Jose Abreu <joabreu@...opsys.com>, Alexandre
Torgue <alexandre.torgue@...s.st.com>, Giuseppe Cavallaro
<peppe.cavallaro@...com>, Simon Horman <simon.horman@...igine.com>
Subject: Re: [PATCH net-next v4 2/4] net: ethernet: altera-tse: Convert to
mdio-regmap and use PCS Lynx
Hi,
On Thu, 1 Jun 2023 16:14:52 +0200
Maxime Chevallier <maxime.chevallier@...tlin.com> wrote:
> The newly introduced regmap-based MDIO driver allows for an easy mapping
> of an mdiodevice onto the memory-mapped TSE PCS, which is actually a
> Lynx PCS.
>
> Convert Altera TSE to use this PCS instead of the pcs-altera-tse, which
> is nothing more than a memory-mapped Lynx PCS.
>
> Signed-off-by: Maxime Chevallier <maxime.chevallier@...tlin.com>
[ ... ]
> - ret = request_and_map(pdev, "pcs", &pcs_res,
> - &priv->pcs_base);
> + ret = request_and_map(pdev, "pcs", &pcs_res, &priv->pcs_base);
It turns out I'm missing the zeroing of pcs_regmap_cfg, which can trigger
errors at probe time. I know this series has been applied, and that I can
send a followup fix, but due to the missing regmap patch in the net-next
tree, this series will break altera_tse and dwmac_socfpga anyway,as
mentionned here (and in the cover):
https://lore.kernel.org/netdev/20230605142039.3f8d1530@pc-7.home/
Is reverting the way to go then ?
Best regards,
Maxime
Powered by blists - more mailing lists