netdev - Re: [PATCH v3 0/1] gro: decrease size of CB

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Mon, 5 Jun 2023 15:58:23 +0200
From: Richard Gobert <richardbgobert@...il.com>
To: Alexander Lobakin <aleksander.lobakin@...el.com>
Cc: davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
	pabeni@...hat.com, lixiaoyan@...gle.com, lucien.xin@...il.com,
	alexanderduyck@...com, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 0/1] gro: decrease size of CB

> I hope you've checked that there's no difference in object code with and
> w/o `inline`? Sometimes the compilers do weird things and stop inlining
> oneliners if they're used more than once. skb_gro_reset_offset() is
> marked `inline` exactly due to that =\

Checked on standard x86-64 and arm64 gcc compilers.
Would you check any other cases?