netdev - Re: [PATCH] net/pppoe: fix a typo for the PPPOE_HASH_BITS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <36743946-9616-88f6-a1f0-5a617cc79c5c@uls.co.za>
Date: Mon, 5 Jun 2023 16:47:05 +0200
From: Jaco Kroon <jaco@....co.za>
To: Simon Horman <simon.horman@...igine.com>,
 Lukas Bulwahn <lukas.bulwahn@...il.com>
Cc: "David S . Miller" <davem@...emloft.net>,
 Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
 Paolo Abeni <pabeni@...hat.com>, netdev@...r.kernel.org,
 kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net/pppoe: fix a typo for the PPPOE_HASH_BITS_1
 definition

On 2023/06/05 14:16, Simon Horman wrote:
> On Mon, Jun 05, 2023 at 09:27:43AM +0200, Lukas Bulwahn wrote:
>> Instead of its intention to define PPPOE_HASH_BITS_1, commit 96ba44c637b0
>> ("net/pppoe: make number of hash bits configurable") actually defined
>> config PPPOE_HASH_BITS_2 twice in the ppp's Kconfig file due to a quick
>> typo with the numbers.
>>
>> Fix the typo and define PPPOE_HASH_BITS_1.
>>
>> Fixes: 96ba44c637b0 ("net/pppoe: make number of hash bits configurable")
>> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@...il.com>
> Reviewed-by: Simon Horman <simon.horman@...igine.com>
>
Reviewed-by: Jaco Kroon <jaco@....co.za>

Sorry about that, that was indeed blonde.  Thanks for the fixup.

Kind Regards,
Jaco