netdev - Re: [PATCH v13 2/7] net: introduce napi_busy_loop

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <qvqwilc1yf8e.fsf@devbig1114.prn1.facebook.com>
Date: Mon, 05 Jun 2023 10:45:55 -0700
From: Stefan Roesch <shr@...kernel.io>
To: Jakub Kicinski <kuba@...nel.org>
Cc: io-uring@...r.kernel.org, kernel-team@...com, axboe@...nel.dk,
 ammarfaizi2@...weeb.org, netdev@...r.kernel.org, olivier@...llion01.com
Subject: Re: [PATCH v13 2/7] net: introduce napi_busy_loop_rcu()


Jakub Kicinski <kuba@...nel.org> writes:

> On Thu, 18 May 2023 14:17:46 -0700 Stefan Roesch wrote:
>> + * napi_busy_loop_rcu() - busy poll (caller holds rcu read lock)
>> + * @napi_id         : napi id
>> + * @loop_end        : function to check for loop end
>> + * @loop_end_arg    : argument for loop end function
>> + * @prefer_busy_poll: prefer busy poll
>> + * @budget          : budget for busy poll
>> + *
>> + * Warning: caller must hold rcu read lock.
>
> I think it's worth noting that until the non-RCU version this one may
> exit without calling need_resched(). Otherwise the entire kdoc can go
> IMO, it adds no value. It just restates the arguments and the RCU-iness
> is obviously implied by the suffix.

I fixed the comment.