netdev - Re: [PATCH net-next] net: txgbe: Avoid passing uninitialised parameter to pci_wake_from

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZH4sBF6frp9YjW4T@kernel.org>
Date: Mon, 5 Jun 2023 20:40:04 +0200
From: Simon Horman <horms@...nel.org>
To: Maciej Fijalkowski <maciej.fijalkowski@...el.com>
Cc: Jakub Kicinski <kuba@...nel.org>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>,
	Jiawen Wu <jiawenwu@...stnetic.com>,
	Mengyuan Lou <mengyuanlou@...-swift.com>,
	Dan Carpenter <dan.carpenter@...aro.com>, netdev@...r.kernel.org
Subject: Re: [PATCH net-next] net: txgbe: Avoid passing uninitialised
 parameter to pci_wake_from_d3()

On Mon, Jun 05, 2023 at 08:22:38PM +0200, Maciej Fijalkowski wrote:
> On Mon, Jun 05, 2023 at 04:20:28PM +0200, Simon Horman wrote:
> 
> Hey Simon,
> 
> > txgbe_shutdown() relies on txgbe_dev_shutdown() to initialise
> > wake by passing it by reference. However, txgbe_dev_shutdown()
> > doesn't use this parameter at all.
> > 
> > wake is then passed uninitialised by txgbe_dev_shutdown()
> > to pci_wake_from_d3().
> > 
> > Resolve this problem by:
> > * Removing the unused parameter from txgbe_dev_shutdown()
> > * Removing the uninitialised variable wake from txgbe_dev_shutdown()
> > * Passing false to pci_wake_from_d3() - this assumes that
> >   although uninitialised wake was in practice false (0).
> > 
> > I'm not sure that this counts as a bug, as I'm not sure that
> > it manifests in any unwanted behaviour. But in any case, the issue
> > was introduced by:
> > 
> >   bbd22f34b47c ("net: txgbe: Avoid passing uninitialised parameter to pci_wake_from_d3()")
> 
> wait, you are pointing to your own commit here?
> 
> this supposed to be:
> 3ce7547e5b71 net: txgbe: Add build support for txgbe
> 
> no?

Yes, sorry about that.

Will fix in a v2.

...

-- 
pw-bot: cr