netdev - Re: [PATCH net-next] ionic: add support for ethtool extended stat link_down

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20230605120505.71f518ae@kernel.org>
Date: Mon, 5 Jun 2023 12:05:05 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Shannon Nelson <shannon.nelson@....com>
Cc: netdev@...r.kernel.org, davem@...emloft.net, brett.creeley@....com,
 drivers@...sando.io, Nitya Sunkad <nitya.sunkad@....com>
Subject: Re: [PATCH net-next] ionic: add support for ethtool extended stat
 link_down_count

On Mon, 5 Jun 2023 09:26:25 -0700 Shannon Nelson wrote:
> > Hm, could you say more about motivation? The ethtool stat is supposed to
> > come from HW and represent PHY-level flap count. It's used primarily to
> > find bad cables in a datacenter. Is this also the use case for ionic?
> > It's unclear to me whether ionic interfaces are seeing an actual PHY or
> > just some virtual link state of the IPU and in the latter case it's not
> > really a match.  
> 
> This is a fair question - yes, it is possible that the FW could fake it, 
> but normally this is a signal from the HW.  However, I suppose it would 
> be best to only have the PF reporting this counter, and not the VFs, 
> which is currently the case here.  I'll have Nitya modify this for PF only.

Perfect, thanks!