[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <09c32c5a-73b4-456f-97f9-685820f3ba25@lunn.ch>
Date: Mon, 5 Jun 2023 21:11:39 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Fernando Eckhardt Valle <fevalle@....br>
Cc: davem@...emloft.net, jesse.brandeburg@...el.com,
anthony.l.nguyen@...el.com, edumazet@...gle.com, kuba@...nel.org,
pabeni@...hat.com, netdev@...r.kernel.org
Subject: Re: [PATCH] igc: enable Mac Address Passthrough in Lenovo
Thunderbolt 4 Docks
On Mon, Jun 05, 2023 at 03:54:07PM -0300, Fernando Eckhardt Valle wrote:
> In order for the Mac Address Passthrough to work with the igc
> driver and the Lenovo Thunderbolt 4 dock station, it is necessary
> to wait for a minimum time of 600ms for the Laptop's MAC address
> to be copied to the Dock. To avoid always waiting for this 600ms
> time, a parameter was created to enable the Mac Address PT and
> also another parameter to modify the waiting time if necessary
> in the future.
Module parameters are very much frowned upon. Please try to find
another solution.
What does the copy of the MAC address? Can it signal when it is done,
and when there is nothing to do?
Andrew
Powered by blists - more mailing lists