netdev - Re: [PATCH v1] net: dsa: realtek: rtl8365mb: add missing case for digital interface 0

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Mon, 5 Jun 2023 13:21:33 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Alvin Šipraga <ALSI@...g-olufsen.dk>
Cc: Christian Lamparter <chunkeey@...il.com>, "netdev@...r.kernel.org"
 <netdev@...r.kernel.org>, "luizluca@...il.com" <luizluca@...il.com>,
 "linus.walleij@...aro.org" <linus.walleij@...aro.org>, "andrew@...n.ch"
 <andrew@...n.ch>, "olteanv@...il.com" <olteanv@...il.com>,
 "f.fainelli@...il.com" <f.fainelli@...il.com>
Subject: Re: [PATCH v1] net: dsa: realtek: rtl8365mb: add missing case for
 digital interface 0

On Sun, 4 Jun 2023 19:19:45 +0000 Alvin Šipraga wrote:
> > so that's why I said it was "by accident" in the commit message.
> > Since the other macros stayed intact.  
> 
> Yes, agree. Do you agree with me though that this doesn't warrant backporting to
> stable as there is no functional change with just the patch on its own?
> i.e. this should be part of a broader series adding RTL8363SB-CG support
> targetting net-next.

+1

> (The Fixes: tag is absolutely fine ofc - stable maintainers
> will tell you that this does not necessarily mean it should go in stable, that's
> what cc: stable@...r is for). If so please add [PATCH v2 net-next] so it goes in
> the right place.

I'd remove the Fixes tag as well, and clearly state in the commit msg
that this patch is a noop for all devices currently supported upstream.
-- 
pw-bot: cr