netdev - Re: [PATCH 03/21] dt-bindings: usb: generic-ehci: Document clock-names property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3b776a90-add5-f870-b20d-0b1bf9b05bc8@linaro.org>
Date: Mon, 5 Jun 2023 08:36:25 +0200
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Varshini Rajendran <varshini.rajendran@...rochip.com>,
 tglx@...utronix.de, maz@...nel.org, robh+dt@...nel.org,
 krzysztof.kozlowski+dt@...aro.org, conor+dt@...nel.org,
 nicolas.ferre@...rochip.com, alexandre.belloni@...tlin.com,
 claudiu.beznea@...rochip.com, davem@...emloft.net, edumazet@...gle.com,
 kuba@...nel.org, pabeni@...hat.com, gregkh@...uxfoundation.org,
 linux@...linux.org.uk, mturquette@...libre.com, sboyd@...nel.org,
 sre@...nel.org, broonie@...nel.org, arnd@...db.de,
 gregory.clement@...tlin.com, sudeep.holla@....com,
 balamanikandan.gunasundar@...rochip.com, mihai.sain@...rochip.com,
 linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org, netdev@...r.kernel.org,
 linux-usb@...r.kernel.org, linux-clk@...r.kernel.org,
 linux-pm@...r.kernel.org
Cc: Hari.PrasathGE@...rochip.com, cristian.birsan@...rochip.com,
 durai.manickamkr@...rochip.com, manikandan.m@...rochip.com,
 dharma.b@...rochip.com, nayabbasha.sayed@...rochip.com,
 balakrishnan.s@...rochip.com
Subject: Re: [PATCH 03/21] dt-bindings: usb: generic-ehci: Document
 clock-names property

On 03/06/2023 22:02, Varshini Rajendran wrote:
> Document the property clock-names in the schema.
> 
> It fixes the dtbs_warning,
> 'clock-names' does not match any of the regexes: 'pinctrl-[0-9]+'

You cut too much from the warning. Which target/board?

> 
> Signed-off-by: Varshini Rajendran <varshini.rajendran@...rochip.com>
> ---
>  Documentation/devicetree/bindings/usb/generic-ehci.yaml | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/usb/generic-ehci.yaml b/Documentation/devicetree/bindings/usb/generic-ehci.yaml
> index 7e486cc6cfb8..542ac26960fc 100644
> --- a/Documentation/devicetree/bindings/usb/generic-ehci.yaml
> +++ b/Documentation/devicetree/bindings/usb/generic-ehci.yaml
> @@ -102,6 +102,10 @@ properties:
>          - if a USB DRD channel: first clock should be host and second
>            one should be peripheral
>  
> +  clock-names:
> +    minItems: 1
> +    maxItems: 4

Not really, because we want them to be fixed, so you need to list the
items. But it seems this is not needed at all... which boards and
drivers use names?


Best regards,
Krzysztof