netdev - Re: [PATCH net] netlink: specs: ethtool: fix random typos

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Mon, 5 Jun 2023 16:37:26 -0700
From: Stanislav Fomichev <sdf@...gle.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: davem@...emloft.net, netdev@...r.kernel.org, edumazet@...gle.com, 
	pabeni@...hat.com
Subject: Re: [PATCH net] netlink: specs: ethtool: fix random typos

On Mon, Jun 5, 2023 at 4:33 PM Jakub Kicinski <kuba@...nel.org> wrote:
>
> Working on the code gen for C reveals typos in the ethtool spec
> as the compiler tries to find the names in the existing uAPI
> header. Fix the mistakes.
>
> Fixes: a353318ebf24 ("tools: ynl: populate most of the ethtool spec")
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>

Acked-by: Stanislav Fomichev <sdf@...gle.com>

Ooopsie, thanks!

> ---
> CC: sdf@...gle.com
> ---
>  Documentation/netlink/specs/ethtool.yaml | 32 ++++++++++++------------
>  1 file changed, 16 insertions(+), 16 deletions(-)
>
> diff --git a/Documentation/netlink/specs/ethtool.yaml b/Documentation/netlink/specs/ethtool.yaml
> index 3abc576ff797..4846345bade4 100644
> --- a/Documentation/netlink/specs/ethtool.yaml
> +++ b/Documentation/netlink/specs/ethtool.yaml
> @@ -223,7 +223,7 @@ doc: Partial family for Ethtool Netlink.
>          name: tx-min-frag-size
>          type: u32
>        -
> -        name: tx-min-frag-size
> +        name: rx-min-frag-size
>          type: u32
>        -
>          name: verify-enabled
> @@ -294,7 +294,7 @@ doc: Partial family for Ethtool Netlink.
>          name: master-slave-state
>          type: u8
>        -
> -        name: master-slave-lanes
> +        name: lanes
>          type: u32
>        -
>          name: rate-matching
> @@ -322,7 +322,7 @@ doc: Partial family for Ethtool Netlink.
>          name: ext-substate
>          type: u8
>        -
> -        name: down-cnt
> +        name: ext-down-cnt
>          type: u32
>    -
>      name: debug
> @@ -577,7 +577,7 @@ doc: Partial family for Ethtool Netlink.
>          name: phc-index
>          type: u32
>    -

[..]

> -    name: cable-test-nft-nest-result
> +    name: cable-test-ntf-nest-result
>      attributes:
>        -
>          name: pair
> @@ -586,7 +586,7 @@ doc: Partial family for Ethtool Netlink.
>          name: code
>          type: u8
>    -
> -    name: cable-test-nft-nest-fault-length
> +    name: cable-test-ntf-nest-fault-length
>      attributes:
>        -
>          name: pair
> @@ -595,16 +595,16 @@ doc: Partial family for Ethtool Netlink.
>          name: cm
>          type: u32
>    -
> -    name: cable-test-nft-nest
> +    name: cable-test-ntf-nest
>      attributes:
>        -
>          name: result
>          type: nest
> -        nested-attributes: cable-test-nft-nest-result
> +        nested-attributes: cable-test-ntf-nest-result
>        -
>          name: fault-length
>          type: nest
> -        nested-attributes: cable-test-nft-nest-fault-length
> +        nested-attributes: cable-test-ntf-nest-fault-length
>    -
>      name: cable-test
>      attributes:
> @@ -618,7 +618,7 @@ doc: Partial family for Ethtool Netlink.
>        -
>          name: nest
>          type: nest
> -        nested-attributes: cable-test-nft-nest
> +        nested-attributes: cable-test-ntf-nest

So much NFTs! Long live NFTs :-D