netdev - Re: [PATCH] net: liquidio: fix mixed module-builtin object

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Tue, 06 Jun 2023 13:15:00 +0200
From: Paolo Abeni <pabeni@...hat.com>
To: Masahiro Yamada <masahiroy@...nel.org>, Jakub Kicinski
 <kuba@...nel.org>,  "David S . Miller" <davem@...emloft.net>,
 netdev@...r.kernel.org
Cc: linux-kernel@...r.kernel.org, Derek Chickles <dchickles@...vell.com>, 
 Satanand Burla <sburla@...vell.com>, Felix Manlunas
 <fmanlunas@...vell.com>, Eric Dumazet <edumazet@...gle.com>,  Nick Terrell
 <terrelln@...com>
Subject: Re: [PATCH] net: liquidio: fix mixed module-builtin object

Hi,

On Sun, 2023-06-04 at 13:32 +0900, Masahiro Yamada wrote:
> With CONFIG_LIQUIDIO=m and CONFIG_LIQUIDIO_VF=y (or vice versa),
> $(common-objs) are linked to a module and also to vmlinux even though
> the expected CFLAGS are different between builtins and modules.
> 
> This is the same situation as fixed by commit 637a642f5ca5 ("zstd:
> Fixing mixed module-builtin objects").
> 
> Introduce the new module, liquidio-core, to provide the common functions
> to liquidio and liquidio-vf.
> 
> Signed-off-by: Masahiro Yamada <masahiroy@...nel.org>

This does not build with allmodconfig:

ERROR: modpost: "lio_get_state_string" [drivers/net/ethernet/cavium/liquidio/liquidio.ko] undefined!
ERROR: modpost: "lio_get_state_string" [drivers/net/ethernet/cavium/liquidio/liquidio_vf.ko] undefined!

Please, when you repost include the 'net-next' tag into the subj.

Thanks!

Paolo