netdev - Re: [ovs-dev] [PATCH net] net: openvswitch: fix upcall counter access before allocation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Tue, 06 Jun 2023 13:57:27 +0200
From: Eelco Chaudron <echaudro@...hat.com>
To: Paolo Abeni <pabeni@...hat.com>
Cc: Simon Horman <horms@...nel.org>, Simon Horman <simon.horman@...igine.com>,
 dev@...nvswitch.org, netdev@...r.kernel.org, edumazet@...gle.com,
 kuba@...nel.org, davem@...emloft.net
Subject: Re: [ovs-dev] [PATCH net] net: openvswitch: fix upcall counter access
 before allocation



On 6 Jun 2023, at 13:43, Paolo Abeni wrote:

> On Mon, 2023-06-05 at 16:38 +0200, Simon Horman wrote:
>> On Mon, Jun 05, 2023 at 03:53:59PM +0200, Eelco Chaudron wrote:
>>>> Yeah, I see that. And I might have done the same thing.
>>>> But, OTOH, this change is making the error path more complex
>>>> (or at least more prone to error).
>>>>
>>>> In any case, the fix looks good.
>>>
>>> Thanks, just to clarify if we get no further feedback on this
>>> patch, do you prefer a v2 with the error path changes?
>>
>> Thanks Eelco,
>>
>> Yes, that is my preference.
>
> I concur with Simon: Eelco, please post a v2 including the error path
> changes.

Our mails crossed, patch should be in your inbox ;)

//Eelco