netdev - Re: [PATCH iproute2-next v3 05/12] dcb: app: modify dcb_app_print

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87o7ls63gh.fsf@nvidia.com>
Date: Tue, 06 Jun 2023 16:08:46 +0200
From: Petr Machata <me@...chata.org>
To: Daniel Machon <daniel.machon@...rochip.com>
Cc: netdev@...r.kernel.org, dsahern@...nel.org, stephen@...workplumber.org,
 petrm@...dia.com, UNGLinuxDriver@...rochip.com
Subject: Re: [PATCH iproute2-next v3 05/12] dcb: app: modify
 dcb_app_print_filtered() for dcb-rewr reuse


Daniel Machon <daniel.machon@...rochip.com> writes:

> Where dcb-app requires protocol to be the printed key, dcb-rewr requires
> it to be the priority. Adapt existing dcb-app print functions for this.
>
> dcb_app_print_filtered() has been modified, to take two callbacks; one
> for printing the entire string (pid and prio), and one for the pid type
> (dec, hex, dscp, pcp). This saves us for making one dedicated function
> for each pid type for both app and rewr.
>
> Also, printing the colon is now expected to be handled by the
> print_pid_prio() callback.
>
> Signed-off-by: Daniel Machon <daniel.machon@...rochip.com>

Reviewed-by: Petr Machata <me@...chata.org>