netdev - Re: [PATCH net] net: sched: move rtm_tca_policy declaration to include file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Tue, 6 Jun 2023 11:54:36 -0400
From: Jamal Hadi Salim <jhs@...atatu.com>
To: Eric Dumazet <edumazet@...gle.com>
Cc: "David S . Miller" <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>, 
	Paolo Abeni <pabeni@...hat.com>, Cong Wang <xiyou.wangcong@...il.com>, 
	Jiri Pirko <jiri@...nulli.us>, netdev@...r.kernel.org, eric.dumazet@...il.com
Subject: Re: [PATCH net] net: sched: move rtm_tca_policy declaration to
 include file

On Tue, Jun 6, 2023 at 7:42 AM Eric Dumazet <edumazet@...gle.com> wrote:
>
> rtm_tca_policy is used from net/sched/sch_api.c and net/sched/cls_api.c,
> thus should be declared in an include file.
>
> This fixes the following sparse warning:
> net/sched/sch_api.c:1434:25: warning: symbol 'rtm_tca_policy' was not declared. Should it be static?
>
> Fixes: e331473fee3d ("net/sched: cls_api: add missing validation of netlink attributes")
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>

Acked-by: Jamal Hadi Salim <jhs@...atatu.com>


cheers,
jamal

>  include/net/pkt_sched.h | 2 ++
>  net/sched/cls_api.c     | 2 --
>  2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/include/net/pkt_sched.h b/include/net/pkt_sched.h
> index f436688b6efc8f20ee5ede6ee94404e22bbebf3f..5722931d83d431d8cc625d44ba2bc22d88301d5b 100644
> --- a/include/net/pkt_sched.h
> +++ b/include/net/pkt_sched.h
> @@ -127,6 +127,8 @@ static inline void qdisc_run(struct Qdisc *q)
>         }
>  }
>
> +extern const struct nla_policy rtm_tca_policy[TCA_MAX + 1];
> +
>  /* Calculate maximal size of packet seen by hard_start_xmit
>     routine of this device.
>   */
> diff --git a/net/sched/cls_api.c b/net/sched/cls_api.c
> index 2621550bfddc1e466b6a03b0ce6eb5de25ab7476..b2432ee04f3193f6bbcb7986fd950d470fd28e55 100644
> --- a/net/sched/cls_api.c
> +++ b/net/sched/cls_api.c
> @@ -43,8 +43,6 @@
>  #include <net/flow_offload.h>
>  #include <net/tc_wrapper.h>
>
> -extern const struct nla_policy rtm_tca_policy[TCA_MAX + 1];
> -
>  /* The list of all installed classifier types */
>  static LIST_HEAD(tcf_proto_base);
>
> --
> 2.41.0.rc0.172.g3f132b7071-goog
>