netdev - RE: [RFC PATCH v7 2/8] dpll: Add DPLL framework base functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <DM6PR11MB4657A72115D17EB5ED702C999B52A@DM6PR11MB4657.namprd11.prod.outlook.com>
Date: Tue, 6 Jun 2023 18:55:16 +0000
From: "Kubalewski, Arkadiusz" <arkadiusz.kubalewski@...el.com>
To: Jakub Kicinski <kuba@...nel.org>, Vadim Fedorenko <vadfed@...a.com>
CC: Jiri Pirko <jiri@...nulli.us>, Jonathan Lemon <jonathan.lemon@...il.com>,
	Paolo Abeni <pabeni@...hat.com>, "Olech, Milena" <milena.olech@...el.com>,
	"Michalik, Michal" <michal.michalik@...el.com>,
	"linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, Vadim Fedorenko
	<vadim.fedorenko@...ux.dev>, poros <poros@...hat.com>, mschmidt
	<mschmidt@...hat.com>, "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"linux-clk@...r.kernel.org" <linux-clk@...r.kernel.org>
Subject: RE: [RFC PATCH v7 2/8] dpll: Add DPLL framework base functions

>From: Jakub Kicinski <kuba@...nel.org>
>Sent: Thursday, May 4, 2023 10:28 PM
>
>On Thu, 4 May 2023 13:18:49 +0200 Jiri Pirko wrote:
>> >diff --git a/include/uapi/linux/dpll.h b/include/uapi/linux/dpll.h
>> >index e188bc189754..75eeaa4396eb 100644
>> >--- a/include/uapi/linux/dpll.h
>> >+++ b/include/uapi/linux/dpll.h
>> >@@ -111,6 +111,8 @@ enum dpll_pin_direction {
>> >
>> > #define DPLL_PIN_FREQUENCY_1_HZ		1
>> > #define DPLL_PIN_FREQUENCY_10_MHZ	10000000
>> >+#define DPLL_PIN_FREQUENCY_10_KHZ	10000
>> >+#define DPLL_PIN_FREQUENCY_77_5_KHZ	77500
>>
>> This should be moved to patch #1.
>> please convert to enum, could be unnamed.
>
>+1, you can't edit the YNL-generated files at all.

Fixed.

Thank you,
Arkadiusz