[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Mon, 5 Jun 2023 15:52:53 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Eric Dumazet <edumazet@...gle.com>
Cc: "David S . Miller" <davem@...emloft.net>, Paolo Abeni
<pabeni@...hat.com>, netdev@...r.kernel.org, eric.dumazet@...il.com
Subject: Re: [PATCH net 1/2] rfs: annotate lockless accesses to
sk->sk_rxhash
On Fri, 2 Jun 2023 16:31:40 +0000 Eric Dumazet wrote:
> + if (sk->sk_state == TCP_ESTABLISHED) {
> + /* This READ_ONCE() is paired with the WRITE_ONCE()
> + * from sock_rps_save_rxhash() and sock_rps_reset_rxhash().
> + */
> + sock_rps_record_flow_hash(READ_ONCE(sk->sk_rxhash));
> + }
Hi Eric, the series got "changes requested", a bit unclear why,
I'm guessing it's because it lacks Fixes tags.
I also noticed that the closing bracket above looks misaligned.
Would you mind reposting? If you prefer not to add Fixes tag
a mention that it's intentional in the cover letter is enough.
Powered by blists - more mailing lists