netdev - Re: [PATCH v2 net] tcp: gso: really support BIG TCP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Tue, 6 Jun 2023 10:12:21 +0200
From: Simon Horman <simon.horman@...igine.com>
To: Eric Dumazet <edumazet@...gle.com>
Cc: "David S . Miller" <davem@...emloft.net>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	netdev@...r.kernel.org, eric.dumazet@...il.com,
	Alexander Duyck <alexanderduyck@...com>
Subject: Re: [PATCH v2 net] tcp: gso: really support BIG TCP

On Mon, Jun 05, 2023 at 04:16:47PM +0000, Eric Dumazet wrote:
> We missed that tcp_gso_segment() was assuming skb->len was smaller than 65535 :
> 
> oldlen = (u16)~skb->len;
> 
> This part came with commit 0718bcc09b35 ("[NET]: Fix CHECKSUM_HW GSO problems.")
> 
> This leads to wrong TCP checksum.
> 
> Adapt the code to accept arbitrary packet length.
> 
> v2:
>   - use two csum_add() instead of csum_fold() (Alexander Duyck)
>   - Change delta type to __wsum to reduce casts (Alexander Duyck)
> 
> Fixes: 09f3d1a3a52c ("ipv6/gso: remove temporary HBH/jumbo header")
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> Reviewed-by: Alexander Duyck <alexanderduyck@...com>

Reviewed-by: Simon Horman <simon.horman@...igine.com>