netdev - Re: [PATCH iproute2-next] tc/taprio: print the offload xstats

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Wed, 7 Jun 2023 08:13:35 -0700
From: Stephen Hemminger <stephen@...workplumber.org>
To: Vladimir Oltean <vladimir.oltean@....com>
Cc: netdev@...r.kernel.org, David Ahern <dsahern@...nel.org>
Subject: Re: [PATCH iproute2-next] tc/taprio: print the offload xstats

On Wed,  7 Jun 2023 15:54:41 +0300
Vladimir Oltean <vladimir.oltean@....com> wrote:

> +static int taprio_print_xstats(struct qdisc_util *qu, FILE *f,
> +			       struct rtattr *xstats)
> +{
> +	struct rtattr *st[TCA_TAPRIO_OFFLOAD_STATS_MAX + 1], *nla;
> +
> +	if (!xstats)
> +		return 0;
> +
> +	parse_rtattr_nested(st, TCA_TAPRIO_OFFLOAD_STATS_MAX, xstats);
> +
> +	nla = st[TCA_TAPRIO_OFFLOAD_STATS_WINDOW_DROPS];
> +	if (nla)
> +		print_lluint(PRINT_ANY, "window-drops", " Window drops: %llu",
> +			     rta_getattr_u64(nla));
> +
> +	nla = st[TCA_TAPRIO_OFFLOAD_STATS_TX_OVERRUNS];
> +	if (nla)
> +		print_lluint(PRINT_ANY, "tx-overruns", " Transmit overruns: %llu",
> +			     rta_getattr_u64(nla));
> +

Ok, but the choice of wording here is off. It makes taprio stats different
in style than other qdisc. The convention in other qdisc is not to use upper case,
and use a one word key.

In other words, not "window-drops", " Window drops: %llu" but instead
      "window_drops", " window_drops %llu",