netdev - Re: [net-next 09/15] net/mlx5e: RX, Log error when page

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e7b3ebac-21ab-ad3b-7906-6eb4b81ec985@intel.com>
Date: Wed, 7 Jun 2023 18:24:39 +0200
From: Alexander Lobakin <aleksander.lobakin@...el.com>
To: Saeed Mahameed <saeed@...nel.org>
CC: "David S. Miller" <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>,
	Paolo Abeni <pabeni@...hat.com>, Eric Dumazet <edumazet@...gle.com>, "Saeed
 Mahameed" <saeedm@...dia.com>, <netdev@...r.kernel.org>, Tariq Toukan
	<tariqt@...dia.com>, Leon Romanovsky <leonro@...dia.com>,
	<linux-rdma@...r.kernel.org>, Dragos Tatulea <dtatulea@...dia.com>
Subject: Re: [net-next 09/15] net/mlx5e: RX, Log error when page_pool size is
 too large

From: Saeed Mahameed <saeed@...nel.org>
Date: Tue,  6 Jun 2023 00:12:13 -0700

> From: Dragos Tatulea <dtatulea@...dia.com>
> 
> The page_pool error message is a bit cryptic when the
> requested size is too large. Add a message on the driver
> side to display how many pages were actually requested.

Why not rather expand Page Pool's "gave up with error" into detailed
error messages? I thought we usually go the other way around in the
upstream and make stuff as generic as possible :D
With this patch, you'll have 2 error messages at the same time: Page
Pool's one and then yours.

> 
> Signed-off-by: Dragos Tatulea <dtatulea@...dia.com>
> Reviewed-by: Tariq Toukan <tariqt@...dia.com>
> Signed-off-by: Saeed Mahameed <saeedm@...dia.com>
[...]

Thanks,
Olek