netdev - Re: [net-next 09/15] net/mlx5e: RX, Log error when page

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a2211eeaa8f25d9b2d1d2495e2e2d9de2f81178f.camel@nvidia.com>
Date: Wed, 7 Jun 2023 16:40:08 +0000
From: Dragos Tatulea <dtatulea@...dia.com>
To: "aleksander.lobakin@...el.com" <aleksander.lobakin@...el.com>,
	"saeed@...nel.org" <saeed@...nel.org>
CC: "linux-rdma@...r.kernel.org" <linux-rdma@...r.kernel.org>,
	"davem@...emloft.net" <davem@...emloft.net>, Tariq Toukan
	<tariqt@...dia.com>, "netdev@...r.kernel.org" <netdev@...r.kernel.org>, Leon
 Romanovsky <leonro@...dia.com>, "kuba@...nel.org" <kuba@...nel.org>,
	"edumazet@...gle.com" <edumazet@...gle.com>, Saeed Mahameed
	<saeedm@...dia.com>, "pabeni@...hat.com" <pabeni@...hat.com>
Subject: Re: [net-next 09/15] net/mlx5e: RX, Log error when page_pool size is
 too large

On Wed, 2023-06-07 at 18:24 +0200, Alexander Lobakin wrote:
> From: Saeed Mahameed <saeed@...nel.org>
> Date: Tue,  6 Jun 2023 00:12:13 -0700
> 
> > From: Dragos Tatulea <dtatulea@...dia.com>
> > 
> > The page_pool error message is a bit cryptic when the
> > requested size is too large. Add a message on the driver
> > side to display how many pages were actually requested.
> 
> Why not rather expand Page Pool's "gave up with error" into detailed
> error messages? I thought we usually go the other way around in the
> upstream and make stuff as generic as possible :D
> With this patch, you'll have 2 error messages at the same time: Page
> Pool's one and then yours.
> 
That makes sense. Then you can also print out the values: requested vs the
constant max which is not (yet) exposed. I can prepare a new version of the
patch.

> > 
> > Signed-off-by: Dragos Tatulea <dtatulea@...dia.com>
> > Reviewed-by: Tariq Toukan <tariqt@...dia.com>
> > Signed-off-by: Saeed Mahameed <saeedm@...dia.com>
> [...]
> 
> Thanks,
> Olek

Thanks,
Dragos