netdev - Re: [PATCH net-next v5 04/14] splice, net: Add a splice

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230607095643.38c18ef6@kernel.org>
Date: Wed, 7 Jun 2023 09:56:43 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: David Howells <dhowells@...hat.com>
Cc: netdev@...r.kernel.org, Linus Torvalds <torvalds@...ux-foundation.org>,
 Chuck Lever <chuck.lever@...cle.com>, Boris Pismenny <borisp@...dia.com>,
 John Fastabend <john.fastabend@...il.com>, "David S. Miller"
 <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Paolo Abeni
 <pabeni@...hat.com>, Willem de Bruijn <willemdebruijn.kernel@...il.com>,
 David Ahern <dsahern@...nel.org>, Matthew Wilcox <willy@...radead.org>,
 Jens Axboe <axboe@...nel.dk>, linux-mm@...ck.org,
 linux-kernel@...r.kernel.org, Christoph Hellwig <hch@....de>, Al Viro
 <viro@...iv.linux.org.uk>, Jan Kara <jack@...e.cz>, Jeff Layton
 <jlayton@...nel.org>, David Hildenbrand <david@...hat.com>, Christian
 Brauner <brauner@...nel.org>, linux-fsdevel@...r.kernel.org,
 linux-block@...r.kernel.org
Subject: Re: [PATCH net-next v5 04/14] splice, net: Add a splice_eof op to
 file-ops and socket-ops

On Wed,  7 Jun 2023 15:05:49 +0100 David Howells wrote:
> Add an optional method, ->splice_eof(), to allow splice to indicate the
> premature termination of a splice to struct file_operations and struct
> proto_ops.
> 
> This is called if sendfile() or splice() encounters all of the following
> conditions inside splice_direct_to_actor():
> 
>  (1) the user did not set SPLICE_F_MORE (splice only), and
> 
>  (2) an EOF condition occurred (->splice_read() returned 0), and
> 
>  (3) we haven't read enough to fulfill the request (ie. len > 0 still), and
> 
>  (4) we have already spliced at least one byte.
> 
> A further patch will modify the behaviour of SPLICE_F_MORE to always be
> passed to the actor if either the user set it or we haven't yet read
> sufficient data to fulfill the request.

Reviewed-by: Jakub Kicinski <kuba@...nel.org>