netdev - Re: [PATCH net-next 5/6] sfc: neighbour lookup for TC encap action offload

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Tue, 6 Jun 2023 21:56:58 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: <edward.cree@....com>
Cc: <linux-net-drivers@....com>, <davem@...emloft.net>, <pabeni@...hat.com>,
 <edumazet@...gle.com>, Edward Cree <ecree.xilinx@...il.com>,
 <netdev@...r.kernel.org>, <habetsm.xilinx@...il.com>
Subject: Re: [PATCH net-next 5/6] sfc: neighbour lookup for TC encap action
 offload

On Mon, 5 Jun 2023 20:17:38 +0100 edward.cree@....com wrote:
> +			dev_hold(neigh->egdev = dst->dev);

Please use the ref-tracker enabled helpers in new code.
And the assignment on a separate line, please.