netdev - Re: [PATCH net-next v2] net: liquidio: fix mixed module-builtin object

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZIA6/CBlDN4CyA3h@corigine.com>
Date: Wed, 7 Jun 2023 10:08:28 +0200
From: Simon Horman <simon.horman@...igine.com>
To: Masahiro Yamada <masahiroy@...nel.org>
Cc: linux-kbuild@...r.kernel.org, netdev@...r.kernel.org,
	"David S . Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	linux-kernel@...r.kernel.org,
	Derek Chickles <dchickles@...vell.com>,
	Satanand Burla <sburla@...vell.com>,
	Felix Manlunas <fmanlunas@...vell.com>,
	Nick Terrell <terrelln@...com>
Subject: Re: [PATCH net-next v2] net: liquidio: fix mixed module-builtin
 object

On Wed, Jun 07, 2023 at 02:18:49AM +0900, Masahiro Yamada wrote:
> With CONFIG_LIQUIDIO=m and CONFIG_LIQUIDIO_VF=y (or vice versa),
> $(common-objs) are linked to a module and also to vmlinux even though
> the expected CFLAGS are different between builtins and modules.
> 
> This is the same situation as fixed by commit 637a642f5ca5 ("zstd:
> Fixing mixed module-builtin objects").
> 
> Introduce the new module, liquidio-core, to provide the common functions
> to liquidio and liquidio-vf.
> 
> Signed-off-by: Masahiro Yamada <masahiroy@...nel.org>
> Reviewed-by: Simon Horman <simon.horman@...igine.com>
> ---
> 
> Changes in v2:
>   - Export lio_get_state_string
>   - Remove $(common-objs) from Makefile

Thanks. FWIIW, I did verify that an x86_64 allmodconfig build
runs successfully. Apologies to all for missing that in v1.